From: Daniel Vetter Subject: Re: [PATCH 0/6] drm: qemu hardware patches Date: Wed, 6 Nov 2013 11:10:26 +0100 Message-ID: <20131106101026.GF14082@phenom.ffwll.local> References: <1381478473-18159-1-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F504132166 for ; Wed, 6 Nov 2013 02:09:58 -0800 (PST) Received: by mail-ee0-f42.google.com with SMTP id c1so2003442eek.29 for ; Wed, 06 Nov 2013 02:09:57 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Dave Airlie Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org On Wed, Nov 06, 2013 at 01:39:46PM +1000, Dave Airlie wrote: > > Here comes a collection of drm patches for qemu emulated > > virtual graphics cards. Small improvements for cirrus > > and qxl. A new kms driver for the qemu standard vga. > > > > Patches 1-4 can be queued up for merge, unless someone > > finds bugs / problems in review of course. > > Hi Gerd, > > I've merged 1-4, thanks for those. > > > > Patches 5+6 have known issues and are still work-in-progress. > > I'm posing them for early review nevertheless. > > Yeah I'm not really sure I like request_regions for drm drivers, yes > its nice to see things, but the fact > that we always get in trouble with efifb and vesafb and that people > seem to insist on later coming along > and supplying unhelpful patches to fix the lack of return checking, I > generally just steer clear. We've recently started to request_region the intel graphics stolen block. Surprising how much gunk the core pci resource layer loves to put in there, so caught a few real bugs. Also it's a major pain to actually get it to work (some random platform has an off-by-one apparently and fun stuff like that). But I agree that for the mmio bars it's probably not worth the trouble due to vesafb/efifb bonghits. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch