Received: from eggs.gnu.org ([2001:4830:134:3::10]:35952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeBfj-0008J2-1u for qemu-devel@nongnu.org; Wed, 06 Nov 2013 17:34:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeBfh-0004j5-Vw for qemu-devel@nongnu.org; Wed, 06 Nov 2013 17:33:58 -0500 Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:46054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeBfh-0004iz-Pk for qemu-devel@nongnu.org; Wed, 06 Nov 2013 17:33:57 -0500 Date: Wed, 6 Nov 2013 23:33:55 +0100 From: Aurelien Jarno Message-ID: <20131106223355.GA26017@ohm.rr44.fr> References: <1383250929-10288-1-git-send-email-rth@twiddle.net> <1383250929-10288-7-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1383250929-10288-7-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 06/20] tcg-ia64: Avoid unnecessary stop bit in tcg_out_alu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, aliguori@amazon.com On Thu, Oct 31, 2013 at 01:21:55PM -0700, Richard Henderson wrote: > When performing an operation with two input registers, we'd leave > the stop bit (and thus an extra cycle) that's only needed when one > or the other input is a constant. > > Signed-off-by: Richard Henderson > --- > tcg/ia64/tcg-target.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c > index 336781f..b7f74a9 100644 > --- a/tcg/ia64/tcg-target.c > +++ b/tcg/ia64/tcg-target.c > @@ -1044,31 +1044,26 @@ static inline void tcg_out_st(TCGContext *s, TCGType type, TCGReg arg, > } > } > > -static inline void tcg_out_alu(TCGContext *s, uint64_t opc_a1, TCGArg ret, > - TCGArg arg1, int const_arg1, > - TCGArg arg2, int const_arg2) > +static void tcg_out_alu(TCGContext *s, uint64_t opc_a1, TCGReg ret, TCGArg arg1, > + int const_arg1, TCGArg arg2, int const_arg2) > { > - uint64_t opc1, opc2; > + uint64_t opc1 = 0, opc2 = 0; > > if (const_arg1 && arg1 != 0) { > opc1 = tcg_opc_a5(TCG_REG_P0, OPC_ADDL_A5, > TCG_REG_R2, arg1, TCG_REG_R0); > arg1 = TCG_REG_R2; > - } else { > - opc1 = INSN_NOP_M; > } > > if (const_arg2 && arg2 != 0) { > opc2 = tcg_opc_a5(TCG_REG_P0, OPC_ADDL_A5, > TCG_REG_R3, arg2, TCG_REG_R0); > arg2 = TCG_REG_R3; > - } else { > - opc2 = INSN_NOP_I; > } > > - tcg_out_bundle(s, mII, > - opc1, > - opc2, > + tcg_out_bundle(s, (opc1 || opc2 ? mII : miI), > + opc1 ? opc1 : INSN_NOP_M, > + opc2 ? opc2 : INSN_NOP_I, > tcg_opc_a1(TCG_REG_P0, opc_a1, ret, arg1, arg2)); > } > Acked-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net