From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915/vlv: Workaround a punit issue in DDR data rate for 1333. Date: Thu, 7 Nov 2013 15:19:55 +0100 Message-ID: <20131107141955.GT14082@phenom.ffwll.local> References: <1383809007-19552-1-git-send-email-chon.ming.lee@intel.com> <20131107124639.GJ5986@intel.com> <20131107134955.GB31944@clee30-mobl2.gar.corp.intel.com> <20131107140150.GT5986@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45]) by gabe.freedesktop.org (Postfix) with ESMTP id 89D1538CC0 for ; Thu, 7 Nov 2013 06:19:26 -0800 (PST) Received: by mail-ee0-f45.google.com with SMTP id e50so345508eek.4 for ; Thu, 07 Nov 2013 06:19:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131107140150.GT5986@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Nov 07, 2013 at 04:01:50PM +0200, Ville Syrj=E4l=E4 wrote: > On Thu, Nov 07, 2013 at 09:49:55PM +0800, Lee, Chon Ming wrote: > > On 11/07 14:46, Ville Syrj=E4l=E4 wrote: > > > On Thu, Nov 07, 2013 at 03:23:26PM +0800, Chon Ming Lee wrote: > > > > For DDR data rate reporting by Punit in PUNIT_GPU_FREQ_STS, the act= ual > > > > data encoding is 00b=3D800, 01b=3D1066, 10b=3D1333, 11b=3D1333. > > > > = > > > > Some premium VLV sku will get the DDR_DATA_RATE set as 11. As a re= sult, > > > > the turbo frequency reporting will be incorrect without this workar= ound. > > > = > > > Does that mean that the original encoding we used was in fact correct, > > > and the new one is not? > > > = > > = > > The spec documents the encoding is 00b=3D800, 01b=3D1066, 10b=3D1333, 1= 1b=3Dinvalid = > = > There was another encoding in some older spec. And we just changed from > that to the current one. > = > > = > > But after check with the punit owner, the 11b is refer to 1333 as well.= It is > > not invalid anymore. > = > OK. In that case: > = > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch