From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915/vlv: For i915_cur_delayinfo, the max frequency reporting wrong value. Date: Thu, 7 Nov 2013 17:55:58 +0100 Message-ID: <20131107165558.GV14082@phenom.ffwll.local> References: <1383809007-19552-1-git-send-email-chon.ming.lee@intel.com> <1383809007-19552-2-git-send-email-chon.ming.lee@intel.com> <20131107085400.0a4ec895@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D026102280 for ; Thu, 7 Nov 2013 08:55:33 -0800 (PST) Received: by mail-ee0-f43.google.com with SMTP id b47so450269eek.16 for ; Thu, 07 Nov 2013 08:55:32 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131107085400.0a4ec895@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Nov 07, 2013 at 08:54:00AM -0800, Jesse Barnes wrote: > On Thu, 7 Nov 2013 15:23:27 +0800 > Chon Ming Lee wrote: > > > The max frequency reporting is not correct. But there is already an existing > > valleyview_rps_max_freq and valleyview_rps_min_freq to get the > > frequency. Use that for i915_cur_delayinfo. > > > > Signed-off-by: Chon Ming Lee > > --- > > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > > index cae3e9c..5254d95 100644 > > --- a/drivers/gpu/drm/i915/i915_debugfs.c > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > > @@ -972,11 +972,11 @@ static int i915_cur_delayinfo(struct seq_file *m, void *unused) > > seq_printf(m, "PUNIT_REG_GPU_FREQ_STS: 0x%08x\n", freq_sts); > > seq_printf(m, "DDR freq: %d MHz\n", dev_priv->mem_freq); > > > > - val = vlv_punit_read(dev_priv, PUNIT_FUSE_BUS1); > > + val = valleyview_rps_max_freq(dev_priv); > > seq_printf(m, "max GPU freq: %d MHz\n", > > vlv_gpu_freq(dev_priv->mem_freq, val)); > > > > - val = vlv_punit_read(dev_priv, PUNIT_REG_GPU_LFM); > > + val = valleyview_rps_min_freq(dev_priv); > > seq_printf(m, "min GPU freq: %d MHz\n", > > vlv_gpu_freq(dev_priv->mem_freq, val)); > > > > Ok yeah this is just ancient. It never got fixed up when the other > bits were added. > > Reviewed-by: Jesse Barnes Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch