From: Dan Carpenter Date: Fri, 08 Nov 2013 10:01:09 +0000 Subject: [patch] [media] v4l: ti-vpe: checking for IS_ERR() instead of NULL Message-Id: <20131108100109.GN27977@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mauro Carvalho Chehab Cc: Grant Likely , Rob Herring , Archit Taneja , Hans Verkuil , Kamil Debski , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org devm_ioremap() returns NULL on error, it doesn't return an ERR_PTR. Signed-off-by: Dan Carpenter diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 4e58069..e163466 100644 --- a/drivers/media/platform/ti-vpe/vpe.c +++ b/drivers/media/platform/ti-vpe/vpe.c @@ -1962,8 +1962,8 @@ static int vpe_probe(struct platform_device *pdev) * registers based on the sub block base addresses */ dev->base = devm_ioremap(&pdev->dev, res->start, SZ_32K); - if (IS_ERR(dev->base)) { - ret = PTR_ERR(dev->base); + if (!dev->base) { + ret = -ENOMEM; goto v4l2_dev_unreg; }