Received: from eggs.gnu.org ([2001:4830:134:3::10]:40675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VejCe-0000gK-Cj for qemu-devel@nongnu.org; Fri, 08 Nov 2013 05:22:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VejCX-0000aR-SI for qemu-devel@nongnu.org; Fri, 08 Nov 2013 05:22:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VejCX-0000Zz-LV for qemu-devel@nongnu.org; Fri, 08 Nov 2013 05:22:05 -0500 Date: Fri, 8 Nov 2013 18:21:59 +0800 From: Fam Zheng Message-ID: <20131108102159.GC26775@T430s.nay.redhat.com> References: <1383707361-19580-1-git-send-email-gesaint@linux.vnet.ibm.com> <1383707361-19580-3-git-send-email-gesaint@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1383707361-19580-3-git-send-email-gesaint@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V6 2/5] qemu-img: Add infinite loop checking in bdrv_new_open() Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xu Wang Cc: kwolf@redhat.com, wdongxu@linux.vnet.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, Xu Wang , xiawenc@linux.vnet.ibm.com On Tue, 11/05 22:09, Xu Wang wrote: > Every image should be checked if there is infinite loop in backing > file chain before open it. So infinite loop check was added into > bdrv_new_open(). If @filename is opened without the flag > BDRV_O_NO_BACKING, the infinite loop check should be called. > > Signed-off-by: Xu Wang I think this should be squashed into patch 1 so that the checking in collect_image_info_list is kept along the series. Fam > --- > qemu-img.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/qemu-img.c b/qemu-img.c > index d5ec45b..3af7996 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -281,6 +281,14 @@ static BlockDriverState *bdrv_new_open(const char *filename, > drv = NULL; > } > > + /* check backing file loop if the whole chain need to be opened */ > + if (!(flags & BDRV_O_NO_BACKING) && > + !bdrv_backing_chain_okay(filename, fmt)) { > + error_report("bdrv_new_open: Open %s failed. There is loop exists " > + "in the backing chain", filename); > + goto fail; > + } > + > ret = bdrv_open(bs, filename, NULL, flags, drv, &local_err); > if (ret < 0) { > error_report("Could not open '%s': %s", filename, > -- > 1.8.1.4 > >