Received: from eggs.gnu.org ([2001:4830:134:3::10]:40837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VejDQ-0001eu-Hq for qemu-devel@nongnu.org; Fri, 08 Nov 2013 05:23:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VejDK-0000iL-JU for qemu-devel@nongnu.org; Fri, 08 Nov 2013 05:23:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VejDK-0000iH-C0 for qemu-devel@nongnu.org; Fri, 08 Nov 2013 05:22:54 -0500 Date: Fri, 8 Nov 2013 18:22:48 +0800 From: Fam Zheng Message-ID: <20131108102248.GD26775@T430s.nay.redhat.com> References: <1383707361-19580-1-git-send-email-gesaint@linux.vnet.ibm.com> <1383707361-19580-4-git-send-email-gesaint@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1383707361-19580-4-git-send-email-gesaint@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V6 3/5] block: Add check infinite loop in bdrv_img_create() Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xu Wang Cc: kwolf@redhat.com, wdongxu@linux.vnet.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, Xu Wang , xiawenc@linux.vnet.ibm.com On Tue, 11/05 22:09, Xu Wang wrote: > Backing file loop should be checked before qemu-img create command > execution. If loop is found, qemu-img create should be stopped and > an error printed. > > Signed-off-by: Xu Wang > --- > block.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/block.c b/block.c > index 3443117..8423e80 100644 > --- a/block.c > +++ b/block.c > @@ -4670,15 +4670,15 @@ void bdrv_img_create(const char *filename, const char *fmt, > } > > backing_file = get_option_parameter(param, BLOCK_OPT_BACKING_FILE); > + backing_fmt = get_option_parameter(param, BLOCK_OPT_BACKING_FMT); > if (backing_file && backing_file->value.s) { > - if (!strcmp(filename, backing_file->value.s)) { > - error_setg(errp, "Error: Trying to create an image with the " > - "same filename as the backing file"); > + if (!bdrv_new_chain_okay(filename, backing_file->value.s, > + backing_fmt->value.s)) { > + error_report("bdrv_img_create: loop exists, image create failed"); Please use error_setg(errp, "..."); Fam