From: Marek Vasut Date: Sat, 9 Nov 2013 03:27:23 +0100 Subject: [U-Boot] [PATCH v1 3/6] arm: pxa: move SP check from start.S to cpuinfo.c In-Reply-To: <1383945479-6499-4-git-send-email-albert.u.boot@aribaud.net> References: <1383945479-6499-1-git-send-email-albert.u.boot@aribaud.net> <1383945479-6499-3-git-send-email-albert.u.boot@aribaud.net> <1383945479-6499-4-git-send-email-albert.u.boot@aribaud.net> Message-ID: <201311090327.23777.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Albert ARIBAUD, > PXA start.S has a PXA (variant) specific check in > start.S. Move it to cpuinfo.c. > > Signed-off-by: Albert ARIBAUD Either way WFM Acked-by: Marek Vasut > --- > arch/arm/cpu/pxa/cpuinfo.c | 6 ++++++ > arch/arm/cpu/pxa/start.S | 6 ------ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/cpu/pxa/cpuinfo.c b/arch/arm/cpu/pxa/cpuinfo.c > index 9d16079..17d8be5 100644 > --- a/arch/arm/cpu/pxa/cpuinfo.c > +++ b/arch/arm/cpu/pxa/cpuinfo.c > @@ -11,6 +11,12 @@ > #include > #include > > +#ifdef CONFIG_CPU_PXA25X > +#if ((CONFIG_SYS_INIT_SP_ADDR) != 0xfffff800) > +#error "Init SP address must be set to 0xfffff800 for PXA250" > +#endif > +#endif > + > #define CPU_MASK_PXA_PRODID 0x000003f0 > #define CPU_MASK_PXA_REVID 0x0000000f > > diff --git a/arch/arm/cpu/pxa/start.S b/arch/arm/cpu/pxa/start.S > index ae0d13c..eb3243a 100644 > --- a/arch/arm/cpu/pxa/start.S > +++ b/arch/arm/cpu/pxa/start.S > @@ -23,12 +23,6 @@ > #include > #include > > -#ifdef CONFIG_CPU_PXA25X > -#if ((CONFIG_SYS_INIT_SP_ADDR) != 0xfffff800) > -#error "Init SP address must be set to 0xfffff800 for PXA250" > -#endif > -#endif > - > .globl _start > _start: b reset > #ifdef CONFIG_SPL_BUILD Best regards, Marek Vasut