From: Dan Carpenter Subject: [patch] drm/nouveau/disp: add a comment on confusing loop Date: Wed, 13 Nov 2013 10:45:52 +0300 Message-ID: <20131113074552.GE25541@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline Sender: kernel-janitors-owner@vger.kernel.org To: David Airlie , Ben Skeggs Cc: David Herrmann , Dave Airlie , Andy Shevchenko , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org The "ret = -EIO" is deliberate. It's a very uncommon thing to do and it upsets static checkers because they normally would expect "ret == -EIO". Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/dport.c b/drivers/gpu/drm/nouveau/core/engine/disp/dport.c index 1bd4c63..2bc45ae 100644 --- a/drivers/gpu/drm/nouveau/core/engine/disp/dport.c +++ b/drivers/gpu/drm/nouveau/core/engine/disp/dport.c @@ -322,6 +322,7 @@ nouveau_dp_train(struct nouveau_disp *disp, const struct nouveau_dp_func *func, while (*link_bw > (dp->dpcd[1] * 27000)) link_bw++; + /* set ret to -EIO on the last loop iteration */ while ((ret = -EIO) && link_bw[0]) { /* find minimum required lane count at this link rate */ dp->link_nr = dp->dpcd[2] & DPCD_RC02_MAX_LANE_COUNT;