From: Tom Rini Date: Thu, 14 Nov 2013 09:18:45 -0500 Subject: [U-Boot] [PATCH 13/14] ARM: AM43xx: GP_EVM: Add support for DDR3 In-Reply-To: References: <1383625260-22294-1-git-send-email-lokeshvutla@ti.com> <1383625260-22294-14-git-send-email-lokeshvutla@ti.com> <527A4A0D.7040309@ti.com> <52833CCF.2060709@ti.com> Message-ID: <20131114141845.GW420@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Nov 13, 2013 at 09:08:29AM -0500, Vaibhav Bedia wrote: > On Wed, Nov 13, 2013 at 3:48 AM, Lokesh Vutla wrote: > [...] > > I checked with hardware folks. There is no register or some way to tell > > if VTT is present. It is not added in EEPROM also and I have no answer why it > > is not added in EEPROM..:( > > It is specific to boards using DDR3. So its good to have it in board files as I did it here > > instead of adding this check in emif file. > > That EEPROM is clearly not getting used the way i think it should be :\ > I would have made a lot of noise to get details like this added there. > > You should at least check for the GP EVM (if possible) and then enable > VTT. Doing this unconditionally is bound to cause problems later on. > I would also put in a big comment over there so that folks who design > their own board with DDR3 don't miss this fact. I agree, the code should be doing a check for what board we're on and enabling VTT, and a good comment about what's going on here. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: