From: Heiko =?iso-8859-1?q?St=FCbner?= Date: Thu, 14 Nov 2013 15:51:45 +0000 Subject: Re: [patch] pinctrl: rockchip: missing unlock on error in rockchip_set_pull() Message-Id: <201311141651.45966.heiko@sntech.de> List-Id: References: <20131114082254.GE8150@elgon.mountain> In-Reply-To: <20131114082254.GE8150@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Am Donnerstag, 14. November 2013, 09:22:54 schrieb Dan Carpenter: > We need to unlock here before returning -EINVAL. I seem to say this a lot recently: thanks for the catch :-) > Fixes: 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics') > Signed-off-by: Dan Carpenter Acked-by: Heiko Stuebner > diff --git a/drivers/pinctrl/pinctrl-rockchip.c > b/drivers/pinctrl/pinctrl-rockchip.c index e939c28..bfd1824 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank > *bank, data |= (3 << bit); > break; > default: > + spin_unlock_irqrestore(&bank->slock, flags); > dev_err(info->dev, "unsupported pull setting %d\n", > pull); > return -EINVAL;