From: Masahiro Yamada Date: Tue, 19 Nov 2013 13:37:17 +0900 Subject: [U-Boot] [PATCH] include: define bool type in a more portable way In-Reply-To: <20131119121022.30A3.AA925319@jp.panasonic.com> References: <20131118162856.1403C38043B@gemini.denx.de> <20131119121022.30A3.AA925319@jp.panasonic.com> Message-ID: <20131119133716.30AB.AA925319@jp.panasonic.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi. I posted v2 of this patch http://patchwork.ozlabs.org/patch/292258/ I think both of two solutions work. (1) include in common/cmd_test.c but undef true and false. http://patchwork.ozlabs.org/patch/292247/ (2) Do not include and define true and false with enum. http://patchwork.ozlabs.org/patch/292258/ Personally, I prefer (2) to (1) because - we don't need to tweak common/cmd_test.c any more - we can reduce the conflict if we have a plan to update Linux-originated header files. Best Regards Masahiro Yamada