From: Al Viro Subject: Re: inode_permission NULL pointer dereference in 3.13-rc1 Date: Tue, 26 Nov 2013 13:11:34 +0000 Message-ID: <20131126131134.GM10323@ZenIV.linux.org.uk> References: <20131124140413.GA19271@infradead.org> <20131124152758.GL10323@ZenIV.linux.org.uk> <20131125160648.GA4933@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com To: Christoph Hellwig Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:40305 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115Ab3KZNLf (ORCPT ); Tue, 26 Nov 2013 08:11:35 -0500 Content-Disposition: inline In-Reply-To: <20131125160648.GA4933@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Nov 25, 2013 at 08:06:48AM -0800, Christoph Hellwig wrote: > On Sun, Nov 24, 2013 at 03:27:58PM +0000, Al Viro wrote: > > which seems to leave two candidates - follow_dotdot_rcu() and path_init(), > > both setting nd->inode to nd->path.dentry->d_inode... > > > > Could you try to reproduce it with something like > > if (read_seqretry(&mount_lock, nd->m_seq)) > > goto failed; > > slapped before the success exit in follow_dotdot_rcu(), just to see if > > we are hitting some races with umount here? > > Still reproducable with the diff below. Fixed by reverting the RCU'd > vfsmounts. .config, please - all I'm seeing on mine is a bloody awful leak somewhere in VM that I'd been hunting for last week, so the damn thing gets OOMed halfway through xfstests run ;-/