From: Jesse Barnes Subject: Re: [PATCH 1/2] drm/i915/vlv: correct promotion timer value for RC6 Timeout method. Date: Wed, 27 Nov 2013 09:19:40 -0800 Message-ID: <20131127091940.1d5414ef@jbarnes-desktop> References: <1385567043-14626-1-git-send-email-deepak.s@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy4-pub.mail.unifiedlayer.com (oproxy4-pub.mail.unifiedlayer.com [74.220.216.66]) by gabe.freedesktop.org (Postfix) with SMTP id F10E7FA91C for ; Wed, 27 Nov 2013 09:18:20 -0800 (PST) In-Reply-To: <1385567043-14626-1-git-send-email-deepak.s@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: deepak.s@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 27 Nov 2013 21:14:03 +0530 deepak.s@intel.com wrote: > From: Deepak S > > For RC6 Timeout method, we need to set promotion timer to 1750 us ( 1367 > * 1.28 us) > > Signed-off-by: Deepak S > --- > drivers/gpu/drm/i915/intel_pm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 04e9863..cf3d54d 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -4102,7 +4102,8 @@ static void valleyview_enable_rps(struct drm_device *dev) > for_each_ring(ring, dev_priv, i) > I915_WRITE(RING_MAX_IDLE(ring->mmio_base), 10); > > - I915_WRITE(GEN6_RC6_THRESHOLD, 0xc350); > + /* Timer for RC6 Timeout Mode set to 1750 us ( 1367 * 1.28 us) */ > + I915_WRITE(GEN6_RC6_THRESHOLD, 0x557); > > /* allows RC6 residency counter to work */ > I915_WRITE(VLV_COUNTER_CONTROL, Yeah I just sent this one too. I'm fine with either one getting in. I also submitted one to do parallel restore of ring state, which we also want. Care to review my earlier ones? http://lists.freedesktop.org/archives/intel-gfx/2013-November/036112.html http://lists.freedesktop.org/archives/intel-gfx/2013-November/036111.html Thanks, -- Jesse Barnes, Intel Open Source Technology Center