From: Aurelien Jarno Subject: Re: [PATCH] UAPI linux/fs.h: add a warning about wrong ioctl argument types Date: Thu, 28 Nov 2013 00:02:07 +0100 Message-ID: <20131127230207.GF29912@hall.aurel32.net> References: <1385548839-16617-1-git-send-email-aurelien@aurel32.net> <20131127111340.GA24022@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: linux-kernel@vger.kernel.org, Alexander Viro , Theodore Ts'o , linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20131127111340.GA24022@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Nov 27, 2013 at 03:13:40AM -0800, Christoph Hellwig wrote: > Thanks Aurelien, > > the added comment looks good and very useful, > > Reviewed-by: Christoph Hellwig > Thanks for the review. > We don't have any man pages documenting these ioctls or other user > visible documentation, do we? The only documentation I have found about these ioctls is from the ioctl_list(2) manpage, but with different name and defined in . In any case they are correctly defined: 0x80046601 EXT2_IOC_GETFLAGS int * 0x40046602 EXT2_IOC_SETFLAGS const int * 0x80047601 EXT2_IOC_GETVERSION int * 0x40047602 EXT2_IOC_SETVERSION const int * -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net