From: Anthony PERARD Subject: Re: [PATCH v2] libxl: Handle xen_platform_pci=0 case with qemu-xen. Date: Thu, 28 Nov 2013 11:19:59 +0000 Message-ID: <20131128111958.GI10855@perard.uk.xensource.com> References: <1385576494-18878-1-git-send-email-anthony.perard@citrix.com> <1385576494-18878-2-git-send-email-anthony.perard@citrix.com> <1385631853.30237.53.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1385631853.30237.53.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Stefano Stabellini , Ian Jackson , Xen Devel List-Id: xen-devel@lists.xenproject.org On Thu, Nov 28, 2013 at 09:44:13AM +0000, Ian Campbell wrote: > On Wed, 2013-11-27 at 18:21 +0000, Anthony PERARD wrote: > > This should result in QEMU *not* adding the xen-platform device. > > > > Since QEMU 1.6, this can be achieved by using a different qemu machine. > > The one used by libxl is "xenfv", but using QEMU >=1.6 with "-machine > > pc,accel=xen" works as well with only one difference compared to > > "xenfv", there is no xen-platform device. > > > > Signed-off-by: Anthony PERARD > > --- > > tools/libxl/libxl_dm.c | 12 ++++++++++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > > index be39a62..ea773b3 100644 > > --- a/tools/libxl/libxl_dm.c > > +++ b/tools/libxl/libxl_dm.c > > @@ -608,7 +608,8 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc, > > } > > for (i = 0; b_info->extra && b_info->extra[i] != NULL; i++) > > flexarray_append(dm_args, b_info->extra[i]); > > - flexarray_append(dm_args, "-M"); > > + > > + flexarray_append(dm_args, "-machine"); > > I trust that -M and -machine are synonyms which go back at least as far > as the versions of qemu we care about? There are not really synonyms, but you can replace -M by -machine, since 2 years ago, or QEMU 0.15 it's look like. > If so then: > Acked-by: Ian Campbell > > I presume that xen_platform_pci=0 will simply fail with a qemu < 1.6? > Perhaps it is worth mentioning this in the xl.cfg man page? Yes, I'll prepare a patch. -- Anthony PERARD