From: Jan Kara Subject: Re: hole-punch vs fault Date: Mon, 2 Dec 2013 21:11:17 +0100 Message-ID: <20131202201117.GA12253@quack.suse.cz> References: <20131127134831.GI24288@parisc-linux.org> <20131127221932.GA27330@quack.suse.cz> <20131128023343.GJ24288@parisc-linux.org> <20131128044454.GL24288@parisc-linux.org> <20131128221246.GQ8803@dastard> <20131129131154.GA11106@parisc-linux.org> <20131201215221.GW10988@dastard> <20131202083318.GA2188@quack.suse.cz> <20131202155825.GA11028@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Dave Chinner , linux-fsdevel@vger.kernel.org To: Matthew Wilcox Return-path: Received: from cantor2.suse.de ([195.135.220.15]:58481 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757158Ab3LBULU (ORCPT ); Mon, 2 Dec 2013 15:11:20 -0500 Content-Disposition: inline In-Reply-To: <20131202155825.GA11028@parisc-linux.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 02-12-13 08:58:25, Matthew Wilcox wrote: > On Mon, Dec 02, 2013 at 09:33:18AM +0100, Jan Kara wrote: > > > Indeed, XIP could make use of the structures we already > > > have in the struct inode/address space to behave more like a normal > > > filesystem. We already use the mapping tree to store > > > per-page information that is used to serialise truncate vs page > > > faults, so why not make XIP do exactly the same thing? > > I believe that grabbing mmap_sem for writing during truncate (in case of > > ext2 around xip_truncate_page() & truncate_setsize() calls should do the > > trick. But I need to verify with lockdep that it doesn't introduce new > > locking problems. > > Umm ... mmap_sem for write? On each of the tasks that have a file mmaped? > I know we have double_down that orders by memory address, but I don't > think we have an N_down_write(). No, sorry, that was my mistake. I was thinking about threads of a single process racing but the race is there obviously for different processes as well so mmap_sem won't help us. Honza -- Jan Kara SUSE Labs, CR