From: Daniel Vetter Subject: Re: [RFC 00/22] Gen7 batch buffer command parser Date: Wed, 4 Dec 2013 09:13:39 +0100 Message-ID: <20131204081339.GX27344@phenom.ffwll.local> References: <1385484699-51596-1-git-send-email-bradley.d.volkin@intel.com> <20131126193538.GR27344@phenom.ffwll.local> <20131126202414.GA52952@vpg-ubuntu-bdvolkin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com [209.85.215.172]) by gabe.freedesktop.org (Postfix) with ESMTP id B6B3FFB637 for ; Wed, 4 Dec 2013 00:12:54 -0800 (PST) Received: by mail-ea0-f172.google.com with SMTP id q10so10430633ead.31 for ; Wed, 04 Dec 2013 00:12:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <20131126202414.GA52952@vpg-ubuntu-bdvolkin> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: "Volkin, Bradley D" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 26, 2013 at 9:24 PM, Volkin, Bradley D wrote: [snip] > Which "state setup stuff" are you referring to? Something specific in i-g-t or something > more general? The state setup 3D commands as opposed to doing actual rendering commands (with 3D_PRIM). Just to have a bit more realistic cs opcode lengths for micro-benchmarking. [snip] > Ok, I'll look at the hw context code for buffer mgmt. For "purgeable", just via the > madv field in the i915 gem object? Yeah, though I'd extract two tiny helpers (maybe shared with the madvise ioctl) to set an object to purgeable and then resurrect it. The later can obviously fail. The helpers are just so we have a place to throw debug asserts into, maybe there are other needs for in-kernel caches. > Also, there are a couple iterations of the work-in-progress patches. Do you prefer a > cache per ring or a single cache shared by all rings? I've pondered a bunch of reasons for/against the two approaches and I think it won't really matter. Maybe slightly leaning towards per-ring caches since then objects retire in order. Well, until we do preemption ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch