From: Stephen Hemminger Subject: [PATCH net-next 1/3] virtio_net: set multicast filter list to host Date: Mon, 9 Dec 2013 16:16:32 -0800 Message-ID: <20131209161632.5ac96e5a@nehalam.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org To: David Miller , Rusty Russell , "Michael S. Tsirkin" Return-path: Received: from mail-pd0-f176.google.com ([209.85.192.176]:46155 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636Ab3LJASz (ORCPT ); Mon, 9 Dec 2013 19:18:55 -0500 Received: by mail-pd0-f176.google.com with SMTP id w10so6143728pde.21 for ; Mon, 09 Dec 2013 16:18:55 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: The virtio_net driver never sends the multicast address list to the host. This is because send command takes a pointer to scatter list to send but only inserts that one entry into the outgoing scatter list. This bug has been there since: commit f565a7c259d71cc186753653d978c646d2354b36 Author: Alex Williamson Date: Wed Feb 4 09:02:45 2009 +0000 virtio_net: Add a MAC filter table Signed-off-by: Stephen Hemminger --- a/drivers/net/virtio_net.c 2013-12-09 16:12:03.897891975 -0800 +++ b/drivers/net/virtio_net.c 2013-12-09 16:12:36.353164803 -0800 @@ -893,7 +893,7 @@ static bool virtnet_send_command(struct sg_init_one(&hdr, &ctrl, sizeof(ctrl)); sgs[out_num++] = &hdr; - if (out) + for (; out; out = sg_next(out)) sgs[out_num++] = out; if (in) sgs[out_num + in_num++] = in;