From: "Stefan Lippers-Hollmann" Subject: Re: [PATCH] drm/bochs: new driver Date: Fri, 13 Dec 2013 03:30:07 +0000 Message-ID: <201312130330.14647.s.L-H@gmx.de> References: <1386858246-4470-1-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1386858246-4470-1-git-send-email-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Gerd Hoffmann Cc: David Airlie , open list , "open list:DRM DRIVERS" List-Id: dri-devel@lists.freedesktop.org Hi On Thursday 12 December 2013, Gerd Hoffmann wrote: > DRM driver for (virtual) vga cards using the bochs dispi > interface, such as the qemu standard vga (qemu -vga std). >=20 > Don't bother supporting anything but 32bpp for now, even > though the virtual hardware is able to do that. >=20 > Known issue: mmap(/dev/fb0) doesn't work. >=20 > Signed-off-by: Gerd Hoffmann > --- [=E2=80=A6] > diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs= /bochs_mm.c > new file mode 100644 > index 0000000..afe104f > --- /dev/null > +++ b/drivers/gpu/drm/bochs/bochs_mm.c [=E2=80=A6] > +int bochs_gem_create(struct drm_device *dev, u32 size, bool iskernel= , > + struct drm_gem_object **obj) > +{ > + struct bochs_bo *bochsbo; > + int ret; > + > + *obj =3D NULL; > + > + size =3D roundup(size, PAGE_SIZE); [=E2=80=A6] Using roundup() this way will fail to build in 32 bit architectures/=20 i386: ERROR: "__udivdi3" [drivers/gpu/drm/bochs/bochs-drm.ko] undefined! ERROR: "__umoddi3" [drivers/gpu/drm/bochs/bochs-drm.ko] undefined! [drm/bochs works pretty nicely for me on amd64] Regards Stefan Lippers-Hollmann