From: Scott Wood Date: Tue, 17 Dec 2013 17:42:34 -0600 Subject: [U-Boot] [U-Boot, V2] mtd: nand: omap: fix HAM1_SW ecc using default value for ecc.size In-Reply-To: <1386854371-8645-1-git-send-email-nikita@compulab.co.il> References: <1386854371-8645-1-git-send-email-nikita@compulab.co.il> Message-ID: <20131217234234.GA8937@home.buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Dec 12, 2013 at 03:19:31PM +0200, Nikita Kiryanov wrote: > Commit "mtd: nand: omap: enable BCH ECC scheme using ELM for generic > platform" (d016dc42cedbf6102e100fa9ecb58462edfb14f8) changed the way > software ECC is configured, both during boot, and during ecc switch, in a way > that is not backwards compatible with older systems: > > Older version of omap_gpmc.c always assigned ecc.size = 0 when configuring > for software ecc, relying on nand_scan_tail() to select a default for ecc.size > (256), while the new version of omap_gpmc.c assigns ecc.size = pagesize, > which is likely to not be 256. > > Since 1 bit hamming sw ecc is only meant to be used by legacy devices, revert > to the original behavior. > > Cc: Igor Grinberg > Cc: Tom Rini > Cc: Scott Wood > Cc: Pekon Gupta > Signed-off-by: Nikita Kiryanov > Acked-by: Pekon Gupta > > --- > Changes in V2: > - reworded commit title to better reflect what is being affected (Pekon > Gupta) > > drivers/mtd/nand/omap_gpmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-nand-flash.git -Scott