Received: from eggs.gnu.org ([2001:4830:134:3::10]:48789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtK3Q-0006KE-D7 for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:33:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtK3G-0000M9-Iw for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:33:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtK3G-0000Lb-BB for qemu-devel@nongnu.org; Wed, 18 Dec 2013 11:32:50 -0500 Date: Wed, 18 Dec 2013 17:32:38 +0100 From: Igor Mammedov Message-ID: <20131218173238.032887ac@nial.usersys.redhat.com> In-Reply-To: <52B1C646.70000@redhat.com> References: <1386938688-22433-1-git-send-email-imammedo@redhat.com> <87r49c1ioi.fsf@codemonkey.ws> <52B045BB.6010900@redhat.com> <52B17AC4.6080709@redhat.com> <20131218164809.7b4ddb07@nial.usersys.redhat.com> <52B1C646.70000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Peter Maydell , Peter Crosthwaite , Eduardo Habkost , "Michael S. Tsirkin" , marcel.a@redhat.com, qemu-devel , Blue Swirl , Alex Williamson , Gerd Hoffmann , Anthony Liguori , dkoch@verizon.co, Andreas =?ISO-8859-1?B?RuRyYmVy?= On Wed, 18 Dec 2013 16:59:02 +0100 Paolo Bonzini wrote: > Il 18/12/2013 16:48, Igor Mammedov ha scritto: > >> Hotplugging a device is a special case of plugging a device. If a bus > >> or device only supports cold-plug, that can be done using > >> "bc->allow_hotplug = false" or "dc->hotpluggable = false". > > Do we need per instance ability to set "hotpluggable" property? > > For example board might want to mark some CPUs as not hotpluggable. > > I think such fine-grained control could be handled from dc->unplug. > Let's not do anything more than we need, until we need it. I had in mind a lightweight conversion of initial memory to DimmDevices for i386 target and disabling its unplug until initial memory unplug would be properly handled by board and SeaBIOS. > > Paolo