Received: from eggs.gnu.org ([2001:4830:134:3::10]:59389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1e7S-0002Sr-O9 for qemu-devel@nongnu.org; Fri, 10 Jan 2014 10:35:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1e7K-00038n-5E for qemu-devel@nongnu.org; Fri, 10 Jan 2014 10:35:34 -0500 Received: from mail-qe0-x236.google.com ([2607:f8b0:400d:c02::236]:49554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1e7K-00038h-0K for qemu-devel@nongnu.org; Fri, 10 Jan 2014 10:35:26 -0500 Received: by mail-qe0-f54.google.com with SMTP id cy11so4659953qeb.13 for ; Fri, 10 Jan 2014 07:35:25 -0800 (PST) Date: Fri, 10 Jan 2014 10:35:14 -0500 From: "Gabriel L. Somlo" Message-ID: <20140110153513.GD1276@ERROL.INI.CMU.EDU> References: <52CDCDA2.4040206@redhat.com> <20140108233924.GA11234@foober.ini.cmu.edu> <20140109015117.GB19321@redhat.com> <20140109185144.GA1276@ERROL.INI.CMU.EDU> <52CF02A6.8000007@redhat.com> <20140109214436.GB1276@ERROL.INI.CMU.EDU> <52CFE97A.6010301@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <52CFE97A.6010301@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, imammedo@redhat.com, lersek@redhat.com, agraf@suse.de, "Michael S. Tsirkin" On Fri, Jan 10, 2014 at 01:37:14PM +0100, Paolo Bonzini wrote: > Il 09/01/2014 22:44, Gabriel L. Somlo ha scritto: > > 1. hardcode "IRQNoFlags(){2, 8}" and require -no-hpet to prevent XP > > from bluescreening. Basically, this means we don't support XP on > > a VM where HPET is enabled. > >=20 > > 2. conditionally insert "IRQNoFlags(){2, 8}" if _OSI("Darwin") returns > > 0xFFFFFFFF, which is only necessary if we want to run OS X on piix+s= mp > > (all other combinations of (piix vs. q35) x (up vs. smp) work fine > > already). >=20 > _OSI is bad, but (1) is worse. Agreed. > > I still don't get why on real hardware where the HPET has > > "IRQNoFlags(){2, 8}" in its _CRS method XP seems to be OK... >=20 > My laptop has this: > > [...]=20 > > Name (BUF0, ResourceTemplate () > { > Memory32Fixed (ReadOnly, > 0xFED00000, // Address Base > 0x00000400, // Address Length > _Y27) > }) > Method (_CRS, 0, Serialized) // _CRS: Current Resour= ce Settings > { > CreateDWordField (BUF0, \_SB.PCI0.LPC.HPET._Y27._= BAS, HPT0) // _BAS: Base Address > Store (\HPET, HPT0) // HPET comes from a table= that BIOS fills in reserved memory > Return (BUF0) > } > } >=20 > so no IRQs, and my workstation is similar. They are respectively from > Lenovo and Fujitsu. Looks like an Apple quirk. Hmmm, I could have sworn I saw IRQNoFlags on one of my old Dell laptops (Dell Latitude D630), but I just had another look and it's not there, so I was clearly misremembering that ! I think you're right, of all the hardware I currently have access to, only the various Apple machines have IRQNoFlags in HPET._CRS ! Given that, I'm starting to feel better and better about using _OSI(). Michael: regarding your comment about "ConcatenateResTemplate" not being supported by XP: Can I safely assume that as long as it's always on the branch NOT taken by XP, we're OK having it in there ? E.g., if _OSI("Darwin") then ConcatenateResTemplate... else stuff_that_XP_cares_about Once I have that sorted out, I'll send a patch. Thanks, --Gabriel