From: Damien Lespiau Subject: Re: [PATCH 3/3] drm/i915: Set the digital port encoder personality during modeset Date: Fri, 10 Jan 2014 18:13:37 +0000 Message-ID: <20140110181336.GF7892@strange.amr.corp.intel.com> References: <1389113755-2021-1-git-send-email-przanoni@gmail.com> <1389113755-2021-3-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 0006C106727 for ; Fri, 10 Jan 2014 10:13:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <1389113755-2021-3-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Tue, Jan 07, 2014 at 02:55:55PM -0200, Paulo Zanoni wrote: > +static bool > +intel_ddi_ensure_encoder_type(struct intel_encoder *encoder) [...] > + if (connector->base.status == connector_status_connected) { > + DRM_DEBUG_KMS("Can't change DDI %c personality to %s, it has a connected %s device\n", > + port_name(port), > + intel_output_name(new_encoder_type), > + intel_output_name(old_encoder_type)); > + return false; > + } Actually, this test should be: if (old_encoder_type != INTEL_OUTPUT_UNKNOWN && connector->base.status == connector_status_connected) { Otherwise we miss the case I wanted the patch for in the first place: Forcing a not-yet-sexed DDI connector (type == UNKNOWN) on the command line, say. video=HDMI-A-1:1024x768e. In that case, we end up with type == UNKNOWN and connector->base.status == connector_status_connected, but still want to force the DDI personality to HDMI. -- Damien