From: Dan Carpenter Subject: Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union Date: Sat, 18 Jan 2014 13:05:48 +0300 Message-ID: <20140118100547.GS7444@mwanda> References: <52DA4E6A.1000308@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <52DA4E6A.1000308@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Chen Gang Cc: devel@driverdev.osuosl.org, James Hogan , andreas.dilger@intel.com, Greg KH , bergwolf@gmail.com, "linux-kernel@vger.kernel.org" , oleg.drokin@intel.com, jacques-charles.lafoucriere@cea.fr, jinshan.xiong@intel.com, linux-metag@vger.kernel.org On Sat, Jan 18, 2014 at 05:50:34PM +0800, Chen Gang wrote: > Unfortunately, not all compilers assumes the structures within a pack > region also need be packed (e.g. metag), so need add a pack explicitly > to satisfy all compilers. > > The related error (under metag with allmodconfig): > > CC [M] drivers/staging/lustre/lustre/lov/lov_pack.o > drivers/staging/lustre/lustre/lov/lov_pack.c: In function 'lov_getstripe': > drivers/staging/lustre/lustre/lov/lov_pack.c:630: error: duplicate case value > drivers/staging/lustre/lustre/lov/lov_pack.c:630: error: previously used here > > And originally, all related code used "__attribute__((packed))", so > still use it instead of '__packed'. Use __packed. Then at least one line will be correct which is better than nothing. regards, dan carpenter