From: Jesse Barnes Subject: Re: [PATCH] drm/i915: fix HDMI clock readout on Haswell Date: Wed, 22 Jan 2014 12:52:56 -0800 Message-ID: <20140122125256.551e39df@jbarnes-desktop> References: <1390423166-27720-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy7-pub.mail.unifiedlayer.com (oproxy7-pub.mail.unifiedlayer.com [67.222.55.9]) by gabe.freedesktop.org (Postfix) with SMTP id 708B6FBC24 for ; Wed, 22 Jan 2014 12:52:41 -0800 (PST) In-Reply-To: <1390423166-27720-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Wed, 22 Jan 2014 18:39:26 -0200 Paulo Zanoni wrote: > From: Paulo Zanoni > > This stops the WARNs when booting with an HDMI monitor connected. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_ddi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > index fe2967e..cb6a65e 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -663,7 +663,7 @@ static int intel_ddi_calc_wrpll_link(struct drm_i915_private *dev_priv, > p = (wrpll & WRPLL_DIVIDER_POST_MASK) >> WRPLL_DIVIDER_POST_SHIFT; > n = (wrpll & WRPLL_DIVIDER_FB_MASK) >> WRPLL_DIVIDER_FB_SHIFT; > > - return (LC_FREQ * n) / (p * r); > + return ((LC_FREQ * n) * 100) / (p * r); > } > > static void intel_ddi_clock_get(struct intel_encoder *encoder, Yep, looks like units fail. And I failed to replace LC_FREQ with refclk when I added the WRPLL refclk fetching... I'll post an updated patch with both fixed. Thanks, -- Jesse Barnes, Intel Open Source Technology Center