Received: from eggs.gnu.org ([2001:4830:134:3::10]:53044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W65bZ-0007Wo-M8 for qemu-devel@nongnu.org; Wed, 22 Jan 2014 16:45:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W65bT-0002ft-MW for qemu-devel@nongnu.org; Wed, 22 Jan 2014 16:45:01 -0500 Received: from paradis.irqsave.net ([62.212.105.220]:48094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W65bT-0002fh-C1 for qemu-devel@nongnu.org; Wed, 22 Jan 2014 16:44:55 -0500 Date: Wed, 22 Jan 2014 22:44:53 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140122214453.GB4196@irqsave.net> References: <1386862440-8003-1-git-send-email-benoit@irqsave.net> <20140121143309.GM3307@dhcp-200-207.str.redhat.com> <20140121153642.GM9834@irqsave.net> <20140121154449.GO3307@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140121154449.GO3307@dhcp-200-207.str.redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , famz@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com Le Tuesday 21 Jan 2014 =E0 16:44:49 (+0100), Kevin Wolf a =E9crit : > Am 21.01.2014 um 16:36 hat Beno=EEt Canet geschrieben: > > Le Tuesday 21 Jan 2014 =E0 15:33:09 (+0100), Kevin Wolf a =E9crit : > > > Am 12.12.2013 um 16:33 hat Beno=EEt Canet geschrieben: > > > > v5: > > > > block empty node names [Kevin] > > > > factorize setting of node-name option [Kevin] > > > > NULL terminate node_name on removal [Kevin] > > > > make query-named-block-nodes return BlockDeviceInfo structure= [Eric] > > > > Change some doc in query-named-block-nodes [Eric] > > > > Document the choice of the QMP API for node name [Eric] > > > > Use the same authorization as snapshot on block resize [Kevin= ] > > > > Rebase the series [Kevin] > > > >=20 > > > > Beno=EEt Canet (7): > > > > block: Add bs->node_name to hold the name of a bs node of the b= s > > > > graph. > > > > block: Allow the user to define "node-name" option. > > > > qmp: Add a command to list the named BlockDriverState nodes. > > > > qmp: Allow to change password on named block driver states. > > > > block: Create authorizations mechanism for external snapshot an= d > > > > resize. > > > > qmp: Allow block_resize to manipulate bs graph nodes. > > > > qmp: Allow to take external snapshots on bs graphs node. > > >=20 > > > One more general question: Now that we have node names, should > > > bdrv_file_open() use node names rather than device names for refere= nces? > > > (Well, no, come to think of it, it's not really a question, but mor= e of > > > a request ;-)) > > :) > > I don't understand what you mean: I don't see any reference to device= _name in > > bdrv_file_open only one in bdrv_open which is used in a printf. >=20 > I'm talking about the function parameter 'const char *reference', which > references an existing block device rather than opening a new one. It > doesn't directly use device_name, but it calls bdrv_find(). I see: int bdrv_file_open(BlockDriverState **pbs, const char *filename, = =20 QDict *options, int flags, Error **errp)=20 so there is a const char *filename but not const char *reference. also: benoit@localhost:~/qemu (19f7b13...)$ git grep "const char *reference" benoit@localhost:~/qemu (19f7b13...)$=20 Are you talking about something lying in another git branch ? Best regards Beno=EEt >=20 > Kevin