From: Daniel Vetter Subject: Re: [PATCH 00/10] drm/i915: Some less complex FBC fixes Date: Sat, 25 Jan 2014 20:59:49 +0100 Message-ID: <20140125195949.GI9772@phenom.ffwll.local> References: <1390488557-16003-1-git-send-email-ville.syrjala@linux.intel.com> <20140123194759.GC25529@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com [209.85.215.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 44CCBFA3E1 for ; Sat, 25 Jan 2014 11:59:54 -0800 (PST) Received: by mail-ea0-f170.google.com with SMTP id k10so1595096eaj.29 for ; Sat, 25 Jan 2014 11:59:53 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140123194759.GC25529@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 23, 2014 at 07:47:59PM +0000, Chris Wilson wrote: > On Thu, Jan 23, 2014 at 04:49:07PM +0200, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > Since fixing the FBC locking is a bigger task that will take a while, > > I decided to pull all the simple fixes from my branch and post them > > right away. > > = > > Some of these I've posted before, some others have seen a bit of action > > by being in a public branch. > > = > > The FBC_FENCE_OFF change is just a guess at this point. The odd offset > > just caught my eye while reading throguh i915_reg.h. > = > I didn't spot anything offensive in the series and each patch only does > what it says on the tin. So I am going to stick my neck out and say > = > Reviewed-by: Chris Wilson > = > for the series. Being picky, I guess Fix FBC_FENCE_OFF should only be an > acked-by since we have no way to review it... Entire series merged, and I'll fire up my g4x here to see what happens ;-) Thanks, Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch