From: Wolfgang Denk Date: Mon, 27 Jan 2014 07:50:05 +0100 Subject: [U-Boot] [PATCH 2/7] fdt: add "fdt sign" command In-Reply-To: <52E5FE93.2030306@denx.de> References: <1390632269-8971-1-git-send-email-hs@denx.de> <1390632269-8971-3-git-send-email-hs@denx.de> <52E5FE93.2030306@denx.de> Message-ID: <20140127065005.3F68238033A@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Heiko, In message <52E5FE93.2030306@denx.de> you wrote: > > >> + cfg_noffset = fit_conf_get_node(working_fdt, NULL); > >> + if (!cfg_noffset) > >> + return CMD_RET_FAILURE; > > > > May need to print an error here, since otherwise it won't be clear > > what went wrong. > > Hmm... fit_conf_get_node() prints a dedicated error message if debug is ^^^^^^^^^^^ > activated... I thought this is enough ... ? ^^^^^^^^^ But in production versions (with debug NOT enabled) the user would never know what went wrong? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "It's when they say 2 + 2 = 5 that I begin to argue." - Eric Pepke