From: Daniel Vetter Subject: Re: [PATCH v2 2/2] drm/i915: fix initial timestamps for PP sequencing logic Date: Wed, 29 Jan 2014 20:47:40 +0100 Message-ID: <20140129194640.GA11705@phenom.ffwll.local> References: <1390994741-9137-1-git-send-email-imre.deak@intel.com> <1390994741-9137-2-git-send-email-imre.deak@intel.com> <20140129132627.GB28110@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 12870FAAB4 for ; Wed, 29 Jan 2014 11:47:47 -0800 (PST) Received: by mail-ee0-f44.google.com with SMTP id c13so1157935eek.3 for ; Wed, 29 Jan 2014 11:47:47 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140129132627.GB28110@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 29, 2014 at 01:26:27PM +0000, Chris Wilson wrote: > On Wed, Jan 29, 2014 at 01:25:41PM +0200, Imre Deak wrote: > > The initial jiffies value can be non-0, so set the inital panel power > > sequencer timestamps accordingly. This didn't cause a problem on 64 bit > > machines but on 32 bit jiffies is initially -300*HZ, so if the panel > > power is initally off in the call from edp_panel_vdd_on()-> > > wait_panel_power_cycle() we'd wait up to ~300 sec more than needed. > > > > Signed-off-by: Imre Deak > > I would have set them all to the same value personally, but > Reviewed-by: Chris Wilson Both patches merged, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch