From: Ben Widawsky Subject: Re: [PATCH] [TRIVIAL] drm/i915: Fix HSW debugfs frequency print Date: Wed, 29 Jan 2014 12:22:44 -0800 Message-ID: <20140129202243.GA32231@bwidawsk.net> References: <1391026854-32150-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 97E4511E324 for ; Wed, 29 Jan 2014 12:22:53 -0800 (PST) Content-Disposition: inline In-Reply-To: <1391026854-32150-1-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org Blargh.... this isn't specific to HSW. Title should be s/HSW/gen6|gen7/ On Wed, Jan 29, 2014 at 12:20:54PM -0800, Ben Widawsky wrote: > We need to do the print after we've done the math. > > This was broken when we introduced VLV support. Personally, I think the > interface should go away now that we support it in sysfs. Historically > it has allowed users to do stupid things which we might not allow in the > sysfs interface - so we can keep it I guess. > > commit 0a073b843bcd9a660f76e497182aac97cafddc4c > Author: Jesse Barnes > Date: Wed Apr 17 15:54:58 2013 -0700 > > drm/i915: turbo & RC6 support for VLV v7 > > Reported-by: Rao, Ram R > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index bc8707f..3487b71 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -3230,8 +3230,6 @@ i915_max_freq_set(void *data, u64 val) > > flush_delayed_work(&dev_priv->rps.delayed_resume_work); > > - DRM_DEBUG_DRIVER("Manually setting max freq to %llu\n", val); > - > ret = mutex_lock_interruptible(&dev_priv->rps.hw_lock); > if (ret) > return ret; > @@ -3249,6 +3247,8 @@ i915_max_freq_set(void *data, u64 val) > gen6_set_rps(dev, val); > } > > + DRM_DEBUG_DRIVER("Manually set max freq to %llu\n", val); > + > mutex_unlock(&dev_priv->rps.hw_lock); > > return 0; > -- > 1.8.5.3 > -- Ben Widawsky, Intel Open Source Technology Center