From: "Volkin, Bradley D" Subject: Re: [PATCH 07/13] drm/i915: Add register whitelist for DRM master Date: Wed, 29 Jan 2014 15:18:21 -0800 Message-ID: <20140129231821.GA20009@vpg-ubuntu-bdvolkin> References: <1385484699-51596-1-git-send-email-bradley.d.volkin@intel.com> <1391032514-19136-1-git-send-email-bradley.d.volkin@intel.com> <1391032514-19136-8-git-send-email-bradley.d.volkin@intel.com> <20140129223725.GP28110@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 785EB44909 for ; Wed, 29 Jan 2014 15:18:31 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140129223725.GP28110@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 29, 2014 at 02:37:25PM -0800, Chris Wilson wrote: > On Wed, Jan 29, 2014 at 01:55:08PM -0800, bradley.d.volkin@intel.com wrote: > > From: Brad Volkin > > > > These are used to implement scanline waits in the X server. > > > > Signed-off-by: Brad Volkin > > --- > > drivers/gpu/drm/i915/i915_cmd_parser.c | 30 ++++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915/i915_cmd_parser.c > > index 18d5b05..296e322 100644 > > --- a/drivers/gpu/drm/i915/i915_cmd_parser.c > > +++ b/drivers/gpu/drm/i915/i915_cmd_parser.c > > @@ -234,6 +234,20 @@ static const u32 gen7_blt_regs[] = { > > BCS_SWCTRL, > > }; > > > > +/* Whitelists for the DRM master. Magic numbers are taken from sna, to match. */ > > It would be wiser to use the kernel defines, makes it look like we are > actually in charge. ;-) Will fix, though based on the sna commit history, it looks like you're in charge either way :) > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre