From: Daniel Vetter Subject: Re: [PATCH v2 1/4] drm/i915: Use i915_hw_context to set reset stats Date: Thu, 30 Jan 2014 16:26:08 +0100 Message-ID: <20140130152608.GT17001@phenom.ffwll.local> References: <1391007939-5741-2-git-send-email-mika.kuoppala@intel.com> <1391090475-15814-1-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-la0-f48.google.com (mail-la0-f48.google.com [209.85.215.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BCB711F042 for ; Thu, 30 Jan 2014 07:26:13 -0800 (PST) Received: by mail-la0-f48.google.com with SMTP id mc6so2622210lab.7 for ; Thu, 30 Jan 2014 07:26:12 -0800 (PST) Content-Disposition: inline In-Reply-To: <1391090475-15814-1-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 30, 2014 at 04:01:15PM +0200, Mika Kuoppala wrote: > With full ppgtt support drm_i915_file_private gained knowledge > about the default context. Also reset stats are now inside > i915_hw_context so we can use proper abstraction. > > v2: Move BUG_ON and WARN_ON to more proper locations (Ben) > > Suggested-by: Ben Widawsky > Signed-off-by: Mika Kuoppala > Reviewed-by: Ben Widawsky [snip] > + BUG_ON(!ctx->last_ring); I've changed this to a WARN_ON - killing the entire driver over this seems a bit excessive. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch