From: "Volkin, Bradley D" Subject: Re: [PATCH] intel: Merge i915_drm.h with cmd parser define Date: Thu, 30 Jan 2014 09:28:25 -0800 Message-ID: <20140130172825.GC26611@vpg-ubuntu-bdvolkin> References: <1385484699-51596-1-git-send-email-bradley.d.volkin@intel.com> <1391032648-19227-1-git-send-email-bradley.d.volkin@intel.com> <20140129221321.GM28110@nuc-i3427.alporthouse.com> <20140129222612.GB19431@vpg-ubuntu-bdvolkin> <20140130092056.GM17001@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 549F5101622 for ; Thu, 30 Jan 2014 09:28:39 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140130092056.GM17001@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 30, 2014 at 01:20:57AM -0800, Daniel Vetter wrote: > On Wed, Jan 29, 2014 at 02:26:12PM -0800, Volkin, Bradley D wrote: > > On Wed, Jan 29, 2014 at 02:13:21PM -0800, Chris Wilson wrote: > > > On Wed, Jan 29, 2014 at 01:57:28PM -0800, bradley.d.volkin@intel.com wrote: > > > > From: Brad Volkin > > > > > > > > Signed-off-by: Brad Volkin > > > > --- > > > > include/drm/i915_drm.h | 5 +++-- > > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h > > > > index 2f4eb8c..ba863c4 100644 > > > > --- a/include/drm/i915_drm.h > > > > +++ b/include/drm/i915_drm.h > > > > @@ -27,7 +27,7 @@ > > > > #ifndef _I915_DRM_H_ > > > > #define _I915_DRM_H_ > > > > > > > > -#include > > > > +#include > > > > > > Something about this patch smells very fishy.... > > > > Yeah, I wasn't completely sure about this one. I followed what I thought was > > the procedure for updating the header (i.e. make headers_install in kernel, > > copy to libdrm) and this is what I got. > > I guess either works, so maybe just add a note to the commit message about > the little change. Imo it's better to have a 1:1 copy of the header > generated by the kernel. Sorry, I'm a bit confused. Did I follow the right procedure for updating the header? > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch