From: Wolfgang Denk Date: Mon, 03 Feb 2014 20:15:52 +0100 Subject: [U-Boot] [PATCH v3 6/9] arc: add Arcangel4 board support In-Reply-To: <1391445368-10545-7-git-send-email-abrodkin@synopsys.com> References: <1391445368-10545-1-git-send-email-abrodkin@synopsys.com> <1391445368-10545-7-git-send-email-abrodkin@synopsys.com> Message-ID: <20140203191552.372A9380958@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Alexey Brodkin, In message <1391445368-10545-7-git-send-email-abrodkin@synopsys.com> you wrote: > Arcangel4 is a FPGA-based development board that is used for prototyping and > verification of of both ARC hardware (CPUs) and software running upon CPU. > > Prerequisite is http://patchwork.ozlabs.org/patch/300901/ Is this commentuseful in the commit message? > +#define CONFIG_SYS_MEMTEST_START (CONFIG_SYS_SDRAM_BASE + 0x200) > +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_SDRAM_BASE + 0x1234) This definitely makes no sense at all. Please see bullet 2. in doc/README.memory-test > +#define CONFIG_BAUDRATE 115200 > +#define CONFIG_SYS_BAUDRATE_TABLE {9600, 19200, 38400, 57600, 115200} This is standard, isn't it? So you can omit it. ... > +#define CONFIG_SYS_MEMTEST_START (CONFIG_SYS_SDRAM_BASE + 0x200) > +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_SDRAM_BASE + 0x1234) ... > +#define CONFIG_BAUDRATE 115200 > +#define CONFIG_SYS_BAUDRATE_TABLE {9600, 19200, 38400, 57600, 115200} See above. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de HANDLE WITH EXTREME CARE: This Product Contains Minute Electrically Charged Particles Moving at Velocities in Excess of Five Hundred Million Miles Per Hour.