From: Tom Rini Date: Tue, 4 Feb 2014 15:35:07 -0500 Subject: [U-Boot] [PATCH] zynq: Fix elf header generation In-Reply-To: <487a4ee4eadcd962017c88958709ea5a8f5b8089.1391529572.git.michal.simek@xilinx.com> References: <487a4ee4eadcd962017c88958709ea5a8f5b8089.1391529572.git.michal.simek@xilinx.com> Message-ID: <20140204203507.GD7049@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Feb 04, 2014 at 04:59:45PM +0100, Michal Simek wrote: > This patch is here because of: > "arm: keep all sections in ELF file" > (sha1: 47ed5dd031d7d2c587e6afd386e79ccec1a1b7f7) > > Our tools expect to have elf with only LOAD header. > Without this fix also PHDR, INTERP and DYNAMIC headers > are available in ELF. > > Signed-off-by: Michal Simek [snip] Two things.. > + /* > + * Deprecated: this MMU section is used by pxa at present but > + * should not be used by new boards/CPUs. > + */ > + . = ALIGN(4096); > + .mmutable : { > + *(.mmutable) > + } You don't need this do you? If not, drop it.. [snip] > + /DISCARD/ : { *(.dynsym) } > + /DISCARD/ : { *(.dynbss*) } > + /DISCARD/ : { *(.dynstr*) } > + /DISCARD/ : { *(.dynamic*) } > + /DISCARD/ : { *(.plt*) } > + /DISCARD/ : { *(.interp*) } > + /DISCARD/ : { *(.gnu*) } > + /DISCARD/ : { *(.ARM.exidx*) } > + /DISCARD/ : { *(.gnu.linkonce.armexidx.*) } Here is the difference between your linker script and the main ARM one. Please add a comment block that explains that you need to discard more sections because the user is expected to pass this image on to tools that require them to be dropped so it's clear why there is this delta between the scripts. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: