From: Tom Rini Date: Tue, 4 Feb 2014 17:06:01 -0500 Subject: [U-Boot] [PATCH V4 01/12] fs: fix generic save command implementation In-Reply-To: <1391458870-17930-1-git-send-email-swarren@wwwdotorg.org> References: <1391458870-17930-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <20140204220601.GO7049@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Feb 03, 2014 at 01:20:59PM -0700, Stephen Warren wrote: > From: Stephen Warren > > Fix a few issues with the generic "save" shell command, and fs_write() > function. > > 1) fstypes[].write wasn't filled in for some file-systems, and isn't > checked when used, which could cause crashes/... if executing save > on e.g. fat/ext filesystems. > > 2) fs_write() requires the length argument to be non-zero, since it needs > to know exactly how many bytes to write. Adjust the comments and code > according to this. > > 3) fs_write() wasn't prototyped in like other generic functions; > other code should be able to call this directly rather than invoking > the "save" shell command. > > Signed-off-by: Stephen Warren > Acked-by: Simon Glass Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: