From: "Volkin, Bradley D" Subject: Re: [PATCH 04/13] drm/i915: Reject privileged commands Date: Wed, 5 Feb 2014 10:42:06 -0800 Message-ID: <20140205184206.GC30559@bdvolkin-ubuntu-desktop> References: <1385484699-51596-1-git-send-email-bradley.d.volkin@intel.com> <1391032514-19136-1-git-send-email-bradley.d.volkin@intel.com> <1391032514-19136-5-git-send-email-bradley.d.volkin@intel.com> <87zjm51t52.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id B764548AC for ; Wed, 5 Feb 2014 10:42:19 -0800 (PST) Content-Disposition: inline In-Reply-To: <87zjm51t52.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jani Nikula Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org [snip] On Wed, Feb 05, 2014 at 07:22:33AM -0800, Jani Nikula wrote: > On Wed, 29 Jan 2014, bradley.d.volkin@intel.com wrote: > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > > index 13ed6ed..2b7c26e 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@ -339,21 +339,22 @@ > > /* > > * Commands used only by the command parser > > */ > > -#define MI_SET_PREDICATE MI_INSTR(0x01, 0) > > -#define MI_ARB_CHECK MI_INSTR(0x05, 0) > > -#define MI_RS_CONTROL MI_INSTR(0x06, 0) > > -#define MI_URB_ATOMIC_ALLOC MI_INSTR(0x09, 0) > > -#define MI_PREDICATE MI_INSTR(0x0C, 0) > > -#define MI_RS_CONTEXT MI_INSTR(0x0F, 0) > > -#define MI_TOPOLOGY_FILTER MI_INSTR(0x0D, 0) > > -#define MI_URB_CLEAR MI_INSTR(0x19, 0) > > -#define MI_UPDATE_GTT MI_INSTR(0x23, 0) > > -#define MI_CLFLUSH MI_INSTR(0x27, 0) > > -#define MI_LOAD_REGISTER_MEM MI_INSTR(0x29, 0) > > -#define MI_LOAD_REGISTER_REG MI_INSTR(0x2A, 0) > > -#define MI_RS_STORE_DATA_IMM MI_INSTR(0x2B, 0) > > -#define MI_LOAD_URB_MEM MI_INSTR(0x2C, 0) > > -#define MI_STORE_URB_MEM MI_INSTR(0x2D, 0) > > +#define MI_SET_PREDICATE MI_INSTR(0x01, 0) > > +#define MI_ARB_CHECK MI_INSTR(0x05, 0) > > +#define MI_RS_CONTROL MI_INSTR(0x06, 0) > > +#define MI_URB_ATOMIC_ALLOC MI_INSTR(0x09, 0) > > +#define MI_PREDICATE MI_INSTR(0x0C, 0) > > +#define MI_RS_CONTEXT MI_INSTR(0x0F, 0) > > +#define MI_TOPOLOGY_FILTER MI_INSTR(0x0D, 0) > > +#define MI_LOAD_SCAN_LINES_EXCL MI_INSTR(0x13, 0) > > +#define MI_URB_CLEAR MI_INSTR(0x19, 0) > > +#define MI_UPDATE_GTT MI_INSTR(0x23, 0) > > +#define MI_CLFLUSH MI_INSTR(0x27, 0) > > +#define MI_LOAD_REGISTER_MEM MI_INSTR(0x29, 0) > > +#define MI_LOAD_REGISTER_REG MI_INSTR(0x2A, 0) > > +#define MI_RS_STORE_DATA_IMM MI_INSTR(0x2B, 0) > > +#define MI_LOAD_URB_MEM MI_INSTR(0x2C, 0) > > +#define MI_STORE_URB_MEM MI_INSTR(0x2D, 0) > > Superfluous whitespace change hunk. It adds MI_LOAD_SCAN_LINES_EXCL and adjusts the whitespace to line up. I see that the whitespace change makes the actual change less obvious. I'll try to clean that up. - Brad > > > > #define MI_CONDITIONAL_BATCH_BUFFER_END MI_INSTR(0x36, 0) > > > > #define PIPELINE_SELECT ((0x3<<29)|(0x1<<27)|(0x1<<24)|(0x4<<16)) > > -- > > 1.8.5.2 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Jani Nikula, Intel Open Source Technology Center