From: Wolfgang Denk Date: Thu, 06 Feb 2014 21:26:04 +0100 Subject: [U-Boot] [PATCH 3/3] env: Implement support for AES encryption into fw_* tools In-Reply-To: <201402062041.23537.marex@denx.de> References: <1391658352-24754-1-git-send-email-marex@denx.de> <1391658352-24754-3-git-send-email-marex@denx.de> <20140206121631.243C8380761@gemini.denx.de> <201402062041.23537.marex@denx.de> Message-ID: <20140206202604.35426382293@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek, In message <201402062041.23537.marex@denx.de> you wrote: > > [...] > > All input considered, thanks! I have but a quick question -- why does the fw_* > tools source look _so_ bad ? ... Because it was written more than a decade ago, when rules were not as strict yet, and personal preferences took hold? > ... Don't you think it needs quite some cleanup ? What > do you think please? Cleanup patches are always welcome... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A list is only as strong as its weakest link. -- Don Knuth