From: Wolfgang Denk Date: Tue, 11 Feb 2014 09:21:15 +0100 Subject: [U-Boot] [PATCH] arm/lib: Add get_effective_memsize() to board.c In-Reply-To: <52F958D0.4050004@freescale.com> References: <1392069859-24805-1-git-send-email-yorksun@freescale.com> <1392070794.6733.362.camel@snotra.buserror.net> <52F953CB.8090601@freescale.com> <1392071879.6733.365.camel@snotra.buserror.net> <52F958D0.4050004@freescale.com> Message-ID: <20140211082115.74709380314@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear York Sun, In message <52F958D0.4050004@freescale.com> you wrote: > > I see the benefit of putting the code to common file and modify the > common/cmd_log.c for logbuffer_base(). Can you suggest a location for > get_effective_memsize(void)? Only powerpc uses this function before this patch. > Putting into common.h seems too generic. common/memsize.c ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Software suppliers are trying to make their software packages more ``user-friendly''. . . . Their best approach, so far, has been to take all the old brochures, and stamp the words, ``user-friendly'' on the cover. - Bill Gates