From: Roland McGrath Subject: Re: [RFC][PATCH 1/2] fcntl.h: add new definitions for file-private lock cmd values Date: Tue, 11 Feb 2014 13:49:15 -0800 (PST) Message-ID: <20140211214915.2FB4774438@topped-with-meat.com> References: <1392145436-13983-1-git-send-email-jlayton@redhat.com> <1392145436-13983-2-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: libc-alpha@sourceware.org, linux-fsdevel@vger.kernel.org To: Jeff Layton Return-path: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org In-Reply-To: Jeff Layton's message of Tuesday, 11 February 2014 14:03:55 -0500 <1392145436-13983-2-git-send-email-jlayton@redhat.com> List-Id: linux-fsdevel.vger.kernel.org > +2014-02-11 Jeff Layton > + > + * add new fcntl cmd macros for file-private locks Proper format is: * sysdeps/unix/sysv/linux/bits/fcntl-linux.h (F_GETLKP, F_SETLKP, F_SETLKPW): New macros. > +/* > + * fd "private" POSIX locks. > + * > + * Usually POSIX locks held by a process are released on *any* close and are > + * not inherited across a fork(). Use GNU style for comments, as you see elsewhere in the file. Use two spaces between sentences. Don't use "function()" when referring to a function, just the name. > +#ifndef F_GETLKP > +# define F_GETLKP 36 > +# define F_SETLKP 37 > +# define F_SETLKPW 38 > +#endif These need to be protected by #ifdef __USE_GNU.