From: Tim Deegan Subject: [PATCH] xen: Don't use __builtin_stdarg_start(). Date: Thu, 13 Feb 2014 16:19:11 +0100 Message-ID: <20140213151911.GD82703@deinos.phlegethon.org> References: <1392074974-1488-1-git-send-email-julien.grall@linaro.org> <20140211085317.GB92054@deinos.phlegethon.org> <52FA17E3.9070105@linaro.org> <20140211123515.GD97288@deinos.phlegethon.org> <52FA1945.8010400@linaro.org> <20140211125928.GE97288@deinos.phlegethon.org> <52FA23B4.5060203@linaro.org> <20140211135926.GB10482@deinos.phlegethon.org> <52FA328C.4000103@linaro.org> <20140211143346.GE10482@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WDy4I-000181-Tw for xen-devel@lists.xenproject.org; Thu, 13 Feb 2014 15:19:15 +0000 Content-Disposition: inline In-Reply-To: <20140211143346.GE10482@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: keir@xen.org, ian.campbell@citrix.com, julien.grall@linaro.org, Ian.Jackson@eu.citrix.com, george.dunlap@citrix.com, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org Cset fca49a00 ("netbsd: build fix with gcc 4.5") changed the definition of va_start() to use __builtin_va_start() rather than __builtin_stdarg_start() for GCCs >= 4.5, but in fact GCC dropped __builtin_stdarg_start() before v3.3. Signed-off-by: Tim Deegan --- George: this should fix the build issues Roger was having with GCC 4.5 after my last stdarg patch. diff --git a/xen/include/xen/stdarg.h b/xen/include/xen/stdarg.h index 0283f06..216fe6d 100644 --- a/xen/include/xen/stdarg.h +++ b/xen/include/xen/stdarg.h @@ -1,18 +1,6 @@ #ifndef __XEN_STDARG_H__ #define __XEN_STDARG_H__ -#ifdef __GNUC__ -# define __GNUC_PREREQ__(x, y) \ - ((__GNUC__ == (x) && __GNUC_MINOR__ >= (y)) || \ - (__GNUC__ > (x))) -#else -# define __GNUC_PREREQ__(x, y) 0 -#endif - -#if !__GNUC_PREREQ__(4, 5) -# define __builtin_va_start(ap, last) __builtin_stdarg_start((ap), (last)) -#endif - typedef __builtin_va_list va_list; #define va_start(ap, last) __builtin_va_start((ap), (last)) #define va_end(ap) __builtin_va_end(ap)