From: Guenter Roeck Subject: Re: [PATCH v7 1/1] watchdog: Add tegra watchdog Date: Fri, 14 Feb 2014 12:14:09 -0800 Message-ID: <20140214201409.GA31748@roeck-us.net> References: <1392408185-15387-1-git-send-email-achew@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1392408185-15387-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Chew Cc: wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, katierh-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Andrew, On Fri, Feb 14, 2014 at 12:03:05PM -0800, Andrew Chew wrote: > Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 and > later). This driver will configure one watchdog timer that will reset the > system in the case of a watchdog timeout. > > This driver binds to the nvidia,tegra30-timer device node and gets its > register base from there. > > Signed-off-by: Andrew Chew > Reviewed-by: Guenter Roeck > Tested-by: Stephen Warren > Reviewed-by: Stephen Warren > --- > Changes from v6: > > Removed kref stuff. We can't think of why it's needed here. > Me likes that :-) Many changes since my original review, but I re-confirm my Reviewed-by: above. Guenter