Date: Tue, 18 Feb 2014 09:15:00 +0100 From: Christian Hesse Message-ID: <20140218091500.324235de@leda.localdomain> In-Reply-To: <20140210144821.65cf1a19@leda.localdomain> References: <20140123142700.315e2d3f@leda.localdomain> <20140204095544.65cad0f2@leda.localdomain> <52F1198B.8000706@redhat.com> <20140207141420.54239977@leda.localdomain> <20140208003607.503a44c9@leda.localdomain> <20140208005550.6b7e134d@leda.localdomain> <52F88ED0.8030201@redhat.com> <20140210103056.2f2a950f@leda.localdomain> <52F8C3FC.6000302@redhat.com> <20140210144821.65cf1a19@leda.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/ZzLpOm//WyorKppB8.WlNDN"; protocol="application/pgp-signature" Subject: Re: [linux-lvm] blkid_wiping breaks snapshots Reply-To: LVM general discussion and development List-Id: LVM general discussion and development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: To: LVM general discussion and development Cc: zkabelac@redhat.com --Sig_/ZzLpOm//WyorKppB8.WlNDN Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Christian Hesse on Mon, 2014/02/10 14:48: > Zdenek Kabelac on Mon, 2014/02/10 13:20: > > Dne 10.2.2014 10:30, Christian Hesse napsal(a): > > > Zdenek Kabelac on Mon, 2014/02/10 09:33: > > >> Dne 8.2.2014 00:55, Christian Hesse napsal(a): > > >>> Christian Hesse on Sat, 2014/02/08 00:36: > > >>>> Hello everybody, > > >>>> > > >>>> I think I nailed it down with git bisect. My first bad commit is: > > >>>> > > >>>> 75628f341ad38b68aae33eae0b5700be2a6e5769 > > >>>> configure: enable blkid_wiping by default if the blkid library is > > >>>> present > > >>>> > > >>>> Looks like this wipes data that is still needed... Building a pack= age > > >>>> with '--disable-blkid_wipe' now to verify on another system. > > >>> > > >>> Uh, this only helps part of... > > >>> > > >>> I changed my test setup and used writable snapshots. After that I g= ot: > > >>> > > >>> WARNING: DM_snapshot_cow signature detected on /dev/cvg/snap-home at > > >>> offset 0. Wipe it? [y/n] > > >>> > > >>> (see https://bbs.archlinux.org/viewtopic.php?id=3D176504 for another > > >>> report) > > >>> > > >>> Looks like disabling blkid_wiping fixes this. My snapshot corruption > > >>> still occurs though. :-/ > > >>> Bad thing about it is that the corruption does not occur reliable w= hen > > >>> doing simple tests in 'git bisect'... Out of ideas for now - Will go > > >>> to bed now. > > >> > > >> Now this was helpful, I guess I think what is going on. > > > > > > Great! Waiting for patches then. :D > > > > > > I could provide some more information when needed: > > > > > > * This happens with read only snapshots only. > > > * I could reproduce with commit eaa23d32732c9bc3dd4f948781b5764cf21d8= 4ba > > > (wiping: add support for blkid wiping), so it was introduced there= or > > > before. > > > > > > Should I investigate further or wait for something to test from you? > >=20 > > Is the patch bellow fixing your problem ? > > (It's still not final - but should help) > >=20 > > Zdenek > >=20 > >=20 > > diff --git a/tools/lvcreate.c b/tools/lvcreate.c > > index 638a868..e8b1a7f 100644 > > --- a/tools/lvcreate.c > > +++ b/tools/lvcreate.c > > @@ -772,7 +772,7 @@ static int _read_activation_params(struct > > lvcreate_params *lp, LVM_READ | LVM_WRITE); > >=20 > > /* Must not zero/wipe read only volume */ > > - if (!(lp->permission & LVM_WRITE)) { > > + if (!lp->snapshot && !(lp->permission & LVM_WRITE)) { > > lp->zero =3D 0; > > lp->wipe_signatures =3D 0; > > } >=20 > This looks good to me. I've made some backups now without any corruption. I have not seen anything show up in git master. Or did I miss the final solution? --=20 main(a){char*c=3D/* Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/* Chris get my mail address: */=3D0;b=3Dc[a+= +];) putchar(b-1/(/* gcc -o sig sig.c && ./sig */b/42*2-3)*42);} --Sig_/ZzLpOm//WyorKppB8.WlNDN Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBAgAGBQJTAxaJAAoJEIlFIdfMgPR2wuMH+wQCDWE/JsE74jMzbulWqPbR l/tZizTDdTjEMLGCCoBVTO8ww0RZjgBWABRzdxiPHr0vtkevAhzpG6Wl229NPgkO 3UY2pjKSf4ipldffPvkRmHEMQZWhX6MWsJsOIUJPRBoj6tvcCeIcO+xQleDR15fV ZxDr0AM0KoWZcDjmoq/99I5YrW/DLxqpQV+y864oU/JUtivKM+5w1R/OjgQZOc56 KzrdW37IiUCq1e15/A7T1gr44jwfeVo/yrrR2ou+lMy3d0IsJEx+yMR3eo3BW5br xBOBeWuO7opArB5/aub5/PQr8EirSwLsNzICIoeuDXBEORq0Td7wxxDuLsopuf4= =znlU -----END PGP SIGNATURE----- --Sig_/ZzLpOm//WyorKppB8.WlNDN--