Return-Path: Date: Tue, 18 Feb 2014 11:37:05 -0500 From: Tejun Heo To: Peter Hurley Cc: Ben Hutchings , linux-kernel@vger.kernel.org, Stefan Richter , stable@vger.kernel.org Subject: Re: [PATCH] workqueue: Document exceptions to work item non-reentrancy guarantee Message-ID: <20140218163705.GD30043@htj.dyndns.org> References: <1392493119-9277-1-git-send-email-peter@hurleysoftware.com> <1392687834.10088.17.camel@deadeye.wl.decadent.org.uk> <5302C58E.1070903@hurleysoftware.com> <20140218153056.GC30043@htj.dyndns.org> <53038AD6.9080609@hurleysoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53038AD6.9080609@hurleysoftware.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Tue, Feb 18, 2014 at 11:31:18AM -0500, Peter Hurley wrote: > >It's a pretty dumb thing to do anyway. > > Fragile, yes; dumb, no. At least not from the point-of-view of the > documentation and what the workqueue actually did. But obviously from > your reaction, unintentional design. Well, maybe dumb is too strong a word but these types of edge case interfaces tend to cause subtle issues over time while being marginally useful at best. Sure it helps a couple odd users to write slightly less code, but that's such a marginal gain compared to the fragility it adds by being another one-off thing. So, yeah, it's a silly thing to include in an interface as widely use as workqueue and it's more of a historical remanant than anything else at this point. Thanks. -- tejun