Received: from eggs.gnu.org ([2001:4830:134:3::10]:46586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WI0kS-0002IY-J2 for qemu-devel@nongnu.org; Mon, 24 Feb 2014 13:59:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WI0kK-0006iq-5y for qemu-devel@nongnu.org; Mon, 24 Feb 2014 13:59:28 -0500 Date: Mon, 24 Feb 2014 19:59:14 +0100 From: Hani Benhabiles Message-ID: <20140224185914.GC3855@Inspiron-3521> References: <1393164341-7196-1-git-send-email-kroosec@gmail.com> <8738j86fwa.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8738j86fwa.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] balloon: Fix device name in error message. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Luiz Capitulino On Mon, Feb 24, 2014 at 10:04:05AM +0100, Markus Armbruster wrote: > I agree the error message is bad, but I'm afraid your patch makes it > worse :) > > qemu_balloon() returns zero when balloon_event_fn has not been set with > qemu_add_balloon_handler(). > > Right now, the only device that calls qemu_add_balloon_handler() is > virtio-balloon-device. In theory, there could be others in the future. > > virtio-balloon-device is a virtio-bus device. The bus can be provided > by virtio-balloon-pci or virtio-balloon-ccw. > > Your error message is misleading when it's provided by the latter. > I see. Sorry for not throughly understanding the whole chain yet! I somehow missed virtio-balloon-ccw, thus my false belief that virtio-balloon-pci would be the only one to be ever needed/used. > Moreover, you missed qmp_query_balloon(). > > QERR_DEVICE_NOT_ACTIVE is also used with argument "spice", and the > resulting error message is similarly bad. Perhaps something like this > would do: > > #define QERR_DEVICE_NOT_ACTIVE \ > ERROR_CLASS_DEVICE_NOT_ACTIVE, "No %s device has been activated" Sounds good to me. Will send a patch shortly.