From: Tom Rini Date: Wed, 26 Feb 2014 12:28:06 -0500 Subject: [U-Boot] [PATCH v8 13/14] dm: Enable gpio command to support driver model In-Reply-To: References: <1392674808-6961-1-git-send-email-sjg@chromium.org> <1392674808-6961-14-git-send-email-sjg@chromium.org> <20140226163426.GB16805@bill-the-cat> Message-ID: <20140226172806.GD16805@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Feb 26, 2014 at 10:21:15AM -0700, Simon Glass wrote: > Hi Tom, > > On 26 February 2014 09:34, Tom Rini wrote: > > > On Mon, Feb 17, 2014 at 03:06:47PM -0700, Simon Glass wrote: > > > > > Now that named GPIO banks are supported, along with a way of obtaining > > > the status of a GPIO (input or output), we can provide an enhanced > > > GPIO command for driver model. Where the driver provides its own > > operation > > > for obtaining the GPIO state, this is used, otherwise a generic version > > > is sufficient. > > [snip] > > > +#if defined(CONFIG_DM_GPIO) > > > + /* > > > + * TODO(sjg at chromium.org): Convert this code over to use the GPIO > > > + * uclass interface instead of the numbered GPIO compatibility > > > + * layer. > > > + */ > > > + ret = gpio_lookup_name(str_gpio, NULL, NULL, &gpio); > > > + if (ret) > > > + return cmd_process_error(cmdtp, ret); > > > > Since this is part of the initial "lets show DM code" shouldn't we do > > this TODO before merging? > > > > The problem is that this is generic code, which must work with and without > driver model. So we can't move the command code over to exclusively use > driver model until all GPIO drivers use driver model. OK, since we're inside a CONFIG_DM_GPIO can you just expand the comment a little so it's clear it's blocked by further conversion? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: