From: Masahiro Yamada Date: Fri, 28 Feb 2014 13:50:35 +0900 Subject: [U-Boot] [PATCH 2/4] kbuild: add CONFIG_ prefix to USE_PRIVATE_LIBS In-Reply-To: <530F70D1.9040803@wwwdotorg.org> References: <1393511304-9432-3-git-send-email-yamada.m@jp.panasonic.com> <530F70D1.9040803@wwwdotorg.org> Message-ID: <20140228135034.94DC.AA925319@jp.panasonic.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Stephen, > I think you need to s/USE_PRIVATE_LIBS/USE_PRIVATE_LIBGCC/ throughout > the patch subject and description. With that change, Oops. Good catch! Fixed in v2. > Here, it seems that CONFIG_USE_PRIVATE_LIBGCC can be (a) unset (b) set > to y, (c) set to a specific library path name. > > > diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile > > > +lib-$(CONFIG_USE_PRIVATE_LIBGCC) += _ashldi3.o _ashrdi3.o _divsi3.o \ > > + _lshrdi3.o _modsi3.o _udivsi3.o _umodsi3.o div0.o > > In case (c) above, that will set variable lib-$(the_library_path_name). > I guess that variable simply won't be used, so that's OK, assuming that > the path name doesn't contain any characters that are illegal as a make > variable name. That's probably true though. Right. lib-$(the_library_path_name) is ignored harmlessly. > > diff --git a/spl/Makefile b/spl/Makefile > > > # Add GCC lib > > +ifeq ($(CONFIG_USE_PRIVATE_LIBGCC),y) > > PLATFORM_LIBGCC = arch/$(ARCH)/lib/lib.a > > PLATFORM_LIBS := $(filter-out %/lib.a, $(filter-out -lgcc, $(PLATFORM_LIBS))) $(PLATFORM_LIBGCC) > > endif > > Should the SPL code here also handle case (c) above? I suppose that's a > pre-existing issue, and not related to this patch though, so feel free > to ignore it. case (c) is used only by x86, which does not generate SPL image. That's why this issue has been dismissed so far. Actually I noticed this issue when I was working on this series. But I want to post less invasive patches to solve our issue; slow Kbuild. So I did not touch it. Best Regards Masahiro Yamada