From: Lauri Kasanen Subject: Re: [PATCH] drm/radeon: TTM must be init with cpu-visible VRAM Date: Fri, 28 Feb 2014 17:30:39 +0200 Message-ID: <20140228173039.8192741d.cand@gmx.com> References: <20140227233848.78fffa58.cand@gmx.com> <531058BB.6050100@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by gabe.freedesktop.org (Postfix) with ESMTP id E51D0FBA28 for ; Fri, 28 Feb 2014 07:29:43 -0800 (PST) Received: from Valinor ([84.248.177.169]) by mail.gmx.com (mrgmx102) with ESMTPA (Nemesis) id 0MV30j-1Wj1lz1m7J-00YV7M for ; Fri, 28 Feb 2014 16:29:42 +0100 In-Reply-To: <531058BB.6050100@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Christian =?ISO-8859-15?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, 28 Feb 2014 10:36:59 +0100 Christian K=F6nig wrote: > Am 27.02.2014 22:38, schrieb Lauri Kasanen: > > Without this, a bo may get created in the cpu-inaccessible vram. > > Before the CP engines get setup, all copies are done via cpu memcpy. > > > > This means that the cpu tries to read from inaccessible memory, fails, > > and the radeon module proceeds to disable acceleration. > > > > Doing this has no downsides, as the real VRAM size gets set as soon as = the > > CP engines get init. > > > > This is a candidate for 3.14 fixes. > = > This should be unnecessary, since TTM gets initialized only seeing the = > visible VRAM and later on radeon_ttm_set_active_vram_size gets called to = > increase the limit. > = > If this isn't the case any more we should figure out why instead of = > working around it like this. Negative, TTM gets initialized with real_vram just a few lines above this patch, not visible_vram. - Lauri