From: Daniel Vetter Subject: Re: [PATCH 0/7] drm/i915: Some more w/a'ish stuff Date: Tue, 4 Mar 2014 15:40:23 +0100 Message-ID: <20140304144023.GD17001@phenom.ffwll.local> References: <1391543961-1553-1-git-send-email-ville.syrjala@linux.intel.com> <530F46A4.9080301@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com [209.85.215.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 84618FB728 for ; Tue, 4 Mar 2014 06:40:30 -0800 (PST) Received: by mail-ea0-f175.google.com with SMTP id d10so394729eaj.20 for ; Tue, 04 Mar 2014 06:40:28 -0800 (PST) Content-Disposition: inline In-Reply-To: <530F46A4.9080301@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Antti =?iso-8859-1?Q?Koskip=E4=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Feb 27, 2014 at 04:07:32PM +0200, Antti Koskip=E4=E4 wrote: > On 02/04/2014 09:59 PM, ville.syrjala@linux.intel.com wrote: > > From: Ville Syrj=E4l=E4 > > = > > So I accidentally looked at gen6_init_clock_gating() and noticed a few > > weird things that should have gotten cleaned up years ago. So I did tha= t. > > = > > While doing that I also noticed the WIZ hashing bits, and the fact that > > we weren't following the BSpec recommendation. After doing a few tests > > on IVB and HSW it looks 16x4 is in fact the best option, 8x4 was second > > best and 8x8 (our current default for !SNB) was the worst. I didn't see > > much (if any) difference w/o MSAA, but w/ MSAA 4x there was some change. > > I used xonotic as my benchmark. > > = > > Ville Syrj=E4l=E4 (7): > > drm/i915: Fix SNB GT_MODE register setup > > drm/i915: Assume we implement > > WaStripsFansDisableFastClipPerformanceFix:snb > > drm/i915: There's no need to mask all 3D_CHICKEN bits on SNB > > drm/i915: Disable SF pipelined attribute fetch for SNB > > drm/i915: Change IVB WIZ hashing mode to 16x4 > > drm/i915: Change HSW WIZ hashing mode to 16x4 > > drm/i915: Change BDW WIZ hashing mode to 16x4 > > = > > drivers/gpu/drm/i915/i915_reg.h | 10 +++++++-- > > drivers/gpu/drm/i915/intel_pm.c | 47 +++++++++++++++++++++++++++++++++= +------- > > 2 files changed, 47 insertions(+), 10 deletions(-) > = > For everything except 4/7, which was reviewed by Ken: > = > Reviewed-by: Antti Koskip=E4=E4 Pulled all remaining patches from this thread into dinq from. Thanks for them and the review comments. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch